> On Aug. 11, 2020, 7:16 p.m., Benjamin Mahler wrote: > > src/internal/devolve.cpp > > Lines 248-249 (original), 248-249 (patched) > > <https://reviews.apache.org/r/72738/diff/1/?file=2237298#file2237298line248> > > > > Just to double check, I assume you found this by searching for > > suppressed_roles or some other piece of the message?
No, actually it was a failure of the new test of UpdateFramework with constraints. Double-checked by serached once again and realized that we also have unused `evolve` with no test coverage and a `TODO` for considering removal. Removing that in the preceding patch. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/#review221547 ----------------------------------------------------------- On Aug. 13, 2020, 6:54 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72738/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2020, 6:54 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > This patch adds framework's offer constraints into `Subscribe` and > `UpdateFramework` calls, which is a prerequisite to implementing > constraints-based offer filtering (see MESOS-10161). > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 6e1639a9baf017fa87b274daeedc821389216ddc > include/mesos/v1/scheduler/scheduler.proto > eb5fdeb984b28403bd8281742bd0a5f2053863e3 > src/internal/devolve.cpp 4527c522473b74622055e1765740e3706b95afdb > > > Diff: https://reviews.apache.org/r/72738/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
