----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72727/#review221544 -----------------------------------------------------------
src/examples/test_csi_plugin.cpp Lines 1589-1590 (original), 1613-1614 (patched) <https://reviews.apache.org/r/72727/#comment310599> Here we assume the volume ID is the volume path, but that is not true when `--volume_id_path` is false. In that case, the volume ID and volume path will be different, so I think the mount operation here will fail. - Qian Zhang On Aug. 11, 2020, 11:07 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72727/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2020, 11:07 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > This patch adds additional configuration flags to the > test CSI plugin which are necessary in order to test > the agent's CSI server. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp 214a3ee4481512b025ff054db6ffe15d476b0264 > > > Diff: https://reviews.apache.org/r/72727/diff/2/ > > > Testing > ------- > > These new flags are used in a subsequent test in this chain. > > > Thanks, > > Greg Mann > >
