> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote:
> > Hm.. it seems this was done to support running the tests from an
> > installation?
> >
> > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1
Yes. But this issue exists even from an installation without this fix unless
specified option `--build_dir=/none` explicitly:
```
$PREFIX/libexec/mesos/tests/mesos-tests/mesos-tests
--gtest_filter="ContainerizerTest.ROOT_CGROUPS_BalloonFramework" --verbose
/root/mesos-development/mesos/src/tests/balloon_framework_test.sh: line 8:
/root/mesos-development/mesos/build/src/colors.sh: No such file or directory
/root/mesos-development/mesos/src/tests/balloon_framework_test.sh: line 9:
/root/mesos-development/mesos/build/src/atexit.sh: No such file or directory
```
If user leave the `--source_dir=/nowhere` options as default or specify an
valid path this patch works with the both circumstances.
If use specify both `--source_dir=/nowhere` **(invalid path)** and
`--build_dir=/none` explicitly, there will be following error show up:
```
/usr/local/mesos-develop/libexec/mesos/tests/balloon_framework_test.sh: line 6:
/nowhere/support/colors.sh: No such file or directory
/usr/local/mesos-develop/libexec/mesos/tests/balloon_framework_test.sh: line 7:
/nowhere/support/atexit.sh: No such file or directory
```
I suppose it is confusing users therefore it is necessary to fix it and there
are two methods here:
1. use the original commit I submitted
2. add checks for the source `${MESOS_SOURCE_DIR}/support/colors.sh` to
prevent the `No such file or directory` showing up:
```
FILE="${MESOS_SOURCE_DIR}/support/colors.sh" && test -f $FILE && source
$FILE
FILE="${MESOS_SOURCE_DIR}/support/atexit.sh" && test -f $FILE && source
$FILE
FILE="${MESOS_HELPER_DIR}/colors.sh" && test -f $FILE && source $FILE
FILE="${MESOS_HELPER_DIR}/atexit.sh" && test -f $FILE && source $FILE
```
What's your opinon here and which method will you prefer ?
- Dong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72709/#review221383
-----------------------------------------------------------
On July 27, 2020, 5:34 p.m., Dong Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72709/
> -----------------------------------------------------------
>
> (Updated July 27, 2020, 5:34 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove unnecessary codes which lead to the following warnning
> messages while performing tests:
>
> ...mesos/build/src/colors.sh: No such file or directory
> ...mesos/build/src/atexit.sh: No such file or directory
>
>
> Diffs
> -----
>
> src/tests/balloon_framework_test.sh
> 7d0a4fee200577a5f7b2edbb3b310a07678879dd
> src/tests/disk_full_framework_test.sh
> 62e62cb90ffb5c05f0db1517409179d5b38518e8
> src/tests/dynamic_reservation_framework_test.sh
> c094ed1464c61b6acf647549f1fd83117b135358
> src/tests/no_executor_framework_test.sh
> df282cab6e91645d19d0aa09867e6b45adaf2508
> src/tests/persistent_volume_framework_test.sh
> 6488656c4bd8ad0c6f25a367cf7de2f926dbecf0
> src/tests/test_framework_test.sh 8782e01edc5be3833760fc45e2b545fce100547b
> src/tests/test_http_framework_test.sh
> 256655dfd7697071547f755e8941822b6d51f8a8
>
>
> Diff: https://reviews.apache.org/r/72709/diff/1/
>
>
> Testing
> -------
>
> make tests
>
>
> Thanks,
>
> Dong Zhu
>
>
