> On July 21, 2020, 7:11 a.m., Greg Mann wrote: > > src/CMakeLists.txt > > Lines 338 (patched) > > <https://reviews.apache.org/r/72690/diff/2/?file=2236017#file2236017line338> > > > > Why put the csi isolator implementation in a separate subdirectory, > > while the other volume isolators are in the same directory?
I will add more source files in this subdirectory in the subsequent patches, e.g., `state.proto` for the info that we need to checkpoint for this isolator. Eventually it will have the similar dir structure with https://github.com/apache/mesos/tree/master/src/slave/containerizer/mesos/isolators/docker/volume . > On July 21, 2020, 7:11 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > > Lines 43 (patched) > > <https://reviews.apache.org/r/72690/diff/2/?file=2236019#file2236019line43> > > > > I don't think that this isolator needs a secret generator; just the > > secret resolver is sufficient. It need the secret generator to generate the auth token when instantiate service manager, like: https://github.com/apache/mesos/blob/1.10.0/src/resource_provider/storage/provider.cpp#L575 . - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221272 ----------------------------------------------------------- On July 20, 2020, 4 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72690/ > ----------------------------------------------------------- > > (Updated July 20, 2020, 4 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10152 > https://issues.apache.org/jira/browse/MESOS-10152 > > > Repository: mesos > > > Description > ------- > > Implemented the framework and `create` method of "volume/csi" isolator. > > > Diffs > ----- > > src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792 > src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49 > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72690/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
