> On April 29, 2020, 3:01 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 2517-2519 (original), 2589-2594 (patched) > > <https://reviews.apache.org/r/72399/diff/5/?file=2227708#file2227708line2592> > > > > This stuff looks stale to me, do you think we can remove it?
No, we still have this issue actually, after recovery both `resourceRequests` and `resourceLimits` of each `Container` object in UCR are empty until `MesosContainerizerProcess::update()` is called. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72399/#review220528 ----------------------------------------------------------- On April 29, 2020, 7:53 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72399/ > ----------------------------------------------------------- > > (Updated April 29, 2020, 7:53 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10117 > https://issues.apache.org/jira/browse/MESOS-10117 > > > Repository: mesos > > > Description > ------- > > Updated UCR's `usage()` method to support resource limits. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 2ea033aa1869f07644b10c036fda1698d08aa89b > src/slave/containerizer/mesos/containerizer.cpp > 6aa4f3fe0940575aeea6a63cdb1ca3c77cd2359b > src/tests/slave_recovery_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8 > src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db > > > Diff: https://reviews.apache.org/r/72399/diff/6/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
