> On April 28, 2020, 9:59 a.m., Qian Zhang wrote: > > docs/task-state-reasons.md > > Lines 126-133 (patched) > > <https://reviews.apache.org/r/72410/diff/2/?file=2229076#file2229076line126> > > > > If we revert the changes about > > `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in > > https://reviews.apache.org/r/72442 , then we do not need to update this doc.
I'm not yet convinced that we should remove the new reason, I'd like to better understand why it's not being sent properly and hopefully fix it. > On April 28, 2020, 9:59 a.m., Qian Zhang wrote: > > docs/upgrades.md > > Lines 52 (patched) > > <https://reviews.apache.org/r/72410/diff/2/?file=2229077#file2229077line52> > > > > I think we'd better to have a general description about the task > > resource limits feature (like how [quota > > limits](https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-9-x-quota-guarantees) > > feature was described) rather than just mention CPU limits here. I think this document isn't intended to be a changelog, but rather a guide for operators who need to upgrade a cluster. So, I think we should only mention things here which an operator might run into when upgrading a cluster: changes in existing behavior, possible issues that could occur, etc. Regarding the quota example, IMHO the passage on quota limits could be reduced to the following text: ``` * Quota guarantees, while still functional in Mesos 1.9, are now deprecated. In the future when optimistic offers are fully implemented, a combination of the newly-added quota limits and priority-based preemption will be simpler to use. ``` - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/#review220519 ----------------------------------------------------------- On April 28, 2020, 12:59 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72410/ > ----------------------------------------------------------- > > (Updated April 28, 2020, 12:59 a.m.) > > > Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim > Harper. > > > Bugs: MESOS-10115 > https://issues.apache.org/jira/browse/MESOS-10115 > > > Repository: mesos > > > Description > ------- > > Updated existing documentation for resource limits. > > > Diffs > ----- > > docs/nested-container-and-task-group.md > 3325ff8e3a694ede82e22b24ab258742746c0bb7 > docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 > docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347 > docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0 > > > Diff: https://reviews.apache.org/r/72410/diff/2/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
