----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72413/#review220432 -----------------------------------------------------------
Fix it, then Ship it! docs/executor-http-api.md Lines 11-16 (original), 19-25 (patched) <https://reviews.apache.org/r/72413/#comment308817> Perhaps we should clarify that this is "legacy", or "deprecated" in favor of the HTTP API? Importantly for users to know: we may or may not put new features into the driver, but we'll always include new features in the HTTP API docs/executor-http-api.md Line 51 (original), 72-78 (patched) <https://reviews.apache.org/r/72413/#comment308819> Kind of seems like this should be up in the overview where the agent endpoint is mentioned? docs/executor-http-api.md Lines 76 (patched) <https://reviews.apache.org/r/72413/#comment308818> This is an agent flag for how the operator configures the location, but to vinod's point, what the executor needs to care about is the MESOS_DOMAIN_SOCKET environment variable, right? (FWICT, that's how the default executor determines what to do: https://github.com/apache/mesos/blob/00466fe6138138ead1ca676df37c3af69104956d/src/executor/executor.cpp#L240 ) - Benjamin Mahler On April 22, 2020, 5:44 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72413/ > ----------------------------------------------------------- > > (Updated April 22, 2020, 5:44 a.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated executor API docs to include the domain socket. > > > Diffs > ----- > > docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848 > > > Diff: https://reviews.apache.org/r/72413/diff/1/ > > > Testing > ------- > > Viewed with `site/mesos-website-dev.sh`. > > > Thanks, > > Greg Mann > >
