----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72305/#review220203 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Lines 717 (patched) <https://reviews.apache.org/r/72305/#comment308511> I do not think we need this. src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Lines 719-720 (patched) <https://reviews.apache.org/r/72305/#comment308512> Why do we use different ways to compare `usage` v.s. `softLimit` and `usage` v.s. `limit`? Can we use the same way? - Qian Zhang On April 3, 2020, 9:59 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72305/ > ----------------------------------------------------------- > > (Updated April 3, 2020, 9:59 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > When a container is OOM-killed and its memory usage is over its > soft memory limit but below its hard memory limit, then we send > schedulers REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED to indicate > that the scheduler's task was preferentially OOM-killed because > it had exceeded its memory request. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 15f87ba8c0a1b44fb3380beb0e739af566ab08fc > > > Diff: https://reviews.apache.org/r/72305/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
