----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72211/#review219954 -----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp Lines 4617 (patched) <https://reviews.apache.org/r/72211/#comment308191> s/cannot be set any limits/cannot have any limit set/ src/tests/containerizer/docker_containerizer_tests.cpp Lines 4624-4628 (patched) <https://reviews.apache.org/r/72211/#comment308192> Are we sure this will hold for all systems? Can we just check that the task cgroup's limit is infinite? - Greg Mann On March 16, 2020, 9:22 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72211/ > ----------------------------------------------------------- > > (Updated March 16, 2020, 9:22 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10053 > https://issues.apache.org/jira/browse/MESOS-10053 > > > Repository: mesos > > > Description > ------- > > Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 689a7220a09f2a58dffdf0dc9fd9f0548600be0e > > > Diff: https://reviews.apache.org/r/72211/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
