> On March 6, 2020, 8:06 a.m., Greg Mann wrote: > > src/docker/docker.cpp > > Line 663 (original), 714-716 (patched) > > <https://reviews.apache.org/r/72022/diff/2/?file=2212187#file2212187line714> > > > > Do we want to set the memory reservation here as well? > > Qian Zhang wrote: > I do not think we want to do that because of backward compatibility.
Good point. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72022/#review219816 ----------------------------------------------------------- On March 16, 2020, 9:16 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72022/ > ----------------------------------------------------------- > > (Updated March 16, 2020, 9:16 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10053 > https://issues.apache.org/jira/browse/MESOS-10053 > > > Repository: mesos > > > Description > ------- > > Set resource limits and OOM score adjustment in Docker executor. > > > Diffs > ----- > > src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 > src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd > src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 > > > Diff: https://reviews.apache.org/r/72022/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
