----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72162/#review219657 -----------------------------------------------------------
3rdparty/stout/include/stout/protobuf.hpp Lines 549 (patched) <https://reviews.apache.org/r/72162/#comment307866> Is `double` infinity a better option here given that `JSON::Number` stores a value in `double`? 3rdparty/stout/include/stout/protobuf.hpp Lines 551 (patched) <https://reviews.apache.org/r/72162/#comment307867> It looks like `JSON::parse()` alone can't parse infinite values from a json string that has been serialized by `jsonify()`. If so, can it cause any issues? Do we want a test for such a case? What prevents us from parsing infinite values in `JSON::parse()`? - Andrei Budnik On Фев. 25, 2020, 1:26 д.п., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72162/ > ----------------------------------------------------------- > > (Updated Фев. 25, 2020, 1:26 д.п.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10064 > https://issues.apache.org/jira/browse/MESOS-10064 > > > Repository: mesos > > > Description > ------- > > Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. > > > Diffs > ----- > > 3rdparty/stout/include/stout/jsonify.hpp > 7a239d846de5679e9c2b80aa4e617a72fdeac92c > 3rdparty/stout/include/stout/protobuf.hpp > fcd91d5ea822612e4b32d157fcbc5f0dedeba823 > 3rdparty/stout/tests/protobuf_tests.cpp > 55889dc432a9459965d3dd75052d672828cdea90 > 3rdparty/stout/tests/protobuf_tests.proto > 5e20215fcc69e400358847d0ce943d8c18f2a9e0 > > > Diff: https://reviews.apache.org/r/72162/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
