----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72157/#review219635 -----------------------------------------------------------
Fix it, then Ship it! src/linux/systemd.cpp Lines 31 (patched) <https://reviews.apache.org/r/72157/#comment307845> Hmm... including `stout/posix/os.hpp` looks inconsistent with existing code - do we really need this include, given that `stout/os.hpp` includes it on non-windows? Alternatively, if you want to be explicit about the origin of `os::cloexec()`, then shouldn't that be `stout/os/posix/fcntl.hpp`? src/linux/systemd.cpp Line 352 (original) <https://reviews.apache.org/r/72157/#comment307846> `cloexec(...)` from stout doesn't have this optimization and always calls `fcntl(fd, F_SETFD, ...)`; makes me wonder if we would want to port it there now or later... - Andrei Sekretenko On Feb. 21, 2020, 12:30 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72157/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2020, 12:30 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Removed reimplementation of `cloexec` from systemd activation code. > > > Diffs > ----- > > src/linux/systemd.cpp 9897473115ac0f9809734c109ba412eefd32e59e > > > Diff: https://reviews.apache.org/r/72157/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
