----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72158/ -----------------------------------------------------------
Review request for mesos, Andrei Sekretenko, Greg Mann, and Qian Zhang. Repository: mesos Description ------- This patch fixes the bug when `listenFdsWithName` function returns an empty set of file descriptors on pre-227 systemd versions when `domain_socket_location` value is not equals to the "systemd:unknown". This happens when a user expects a newer version of systemd and specifies a "systemd/<value taken from FileDescriptorName>", but the actual systemd version does not support `FileDescriptorName`. In this case, `LISTEN_FDNAMES` env variable is not specified, so all socket FDs, which are specified by the `LISTEN_FDS`, must be used to locate the path to the domain socket. Diffs ----- src/linux/systemd.cpp 9897473115ac0f9809734c109ba412eefd32e59e Diff: https://reviews.apache.org/r/72158/diff/1/ Testing ------- internal CI (including CoreOS) Thanks, Andrei Budnik
