-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72095/
-----------------------------------------------------------
(Updated Feb. 12, 2020, 5:56 p.m.)
Review request for mesos, Benjamin Mahler and Greg Mann.
Changes
-------
Adjusted for changes in previous patch; expanded description.
Summary (updated)
-----------------
Introduced dedicated `Framework` methods for transitions between states.
Bugs: MESOS-10056
https://issues.apache.org/jira/browse/MESOS-10056
Repository: mesos
Description (updated)
-------
The main purpose of this patch is gathering scattered logic of
transitioning `Framework` to disconnected state into
`Framework::tryDisconnect()` method. This is a prerequisite for adding
to the `Framework` state one more entity that needs cleanup when the
framework is disconnected (namely, adding per-framework
`ObjectApprovers` in depending patches).
For consistency between transition into DISCONNECTED and other state
transitions, this patch also gets rid of public `setFrameworkState(...)`
method and introduces `tryDeactivate()` and `reactivate()` methods.
Diffs (updated)
-----
src/master/framework.cpp e69a7c26d15ffffb3d147328032f996962387c96
src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f
src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e
Diff: https://reviews.apache.org/r/72095/diff/2/
Changes: https://reviews.apache.org/r/72095/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko
