> On Feb. 7, 2020, 7:18 p.m., Benjamin Mahler wrote: > > It seems we also need to look through the tests for any that are now > > redundant? > > > > For example: > > MasterTestPrePostReservationRefinement.StateEndpointPendingTasks, > > DestroyOperationValidationTest.SharedPersistentVolumeInPendingTasks, > > MasterAuthorizationTest.KillPendingTaskInTaskGroup, etc
When converting ACCEPT to synchronous authorization, I took the approach that the patch should not break the tests. Thus, in the previous patch I had to remove tests of any behaviours with regard to tasks pending authorization in-between `accept(...)` and `_accept(...)`, because that 'in-between' no longer exists. Tried to look for any remaining test related to pending tasks - maybe I'm missing something, but there seems to be none left. Those three you mentioned are gone, and I can't find anything else. This is not surprising; finding such a test would mean that it was testing nothing before synchronous authz. If this helps readability, I can split the previous patch into code change and tests cleanup. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72099/#review219525 ----------------------------------------------------------- On Feb. 7, 2020, 5:32 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72099/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2020, 5:32 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > Now that ACCEPT is authorized synchronously, there are no pending > tasks in-between dispatches on `Master` methods, thus the pending task > tracking code is not needed anymore. > > > Diffs > ----- > > src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 > src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f > src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e > src/master/readonly_handler.cpp 40005a2ac2cc9dd6075425c184d220f0a2fbee99 > src/master/validation.hpp b2897132a6bfaa1002663d6aea0fb87246b3d8d8 > src/master/validation.cpp 2f80536dd3810180385351765965ed6211d372c7 > src/tests/master_validation_tests.cpp > e92ff5913ea43f50b0895d7a2b2dd0efd7361083 > > > Diff: https://reviews.apache.org/r/72099/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
