----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72033/#review219341 -----------------------------------------------------------
Typo in description? s/mesos-execute/mesos-executor(.exe)/ - Andrei Sekretenko On Jan. 21, 2020, 12:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72033/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2020, 12:20 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-10084 > https://issues.apache.org/jira/browse/MESOS-10084 > > > Repository: mesos > > > Description > ------- > > We previously were detecting executors generated for command tasks by > checking whether their command matched the full path of > `mesos-executor`. This approach can lead to misdetection if e.g., > during an upgrade a new installation location is choosen. > > This patch adjusts the heuristic by now only relying on the fact that > the executor command should end in `mesos-execute`. In order to cut down > on false positives we now additionally check that the executor name > looks similar to the ones we generate for command tasks. > > > Diffs > ----- > > src/slave/slave.cpp 0005971717f5b90da368b45caad8e209ada95fa5 > > > Diff: https://reviews.apache.org/r/72033/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
