> On Aug. 19, 2019, 7 a.m., Andrei Sekretenko wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 83 (patched) > > <https://reviews.apache.org/r/71301/diff/3/?file=2161236#file2161236line83> > > > > What is wrong with `FrameworkInfo.id()`? Do we really need a separate > > parameter for an id?
Removed the parameter and added a check ensure `FrameworkInfo` from master has id set. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/#review217290 ----------------------------------------------------------- On Aug. 16, 2019, 3:53 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71301/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2019, 3:53 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This provides easy lookup. > > Also refactored related functions to take in `Framework&` > instead of `FrameworkId&`. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 035fd3d7892d4280e299a29f99e8cf6a4c2afb30 > src/master/allocator/mesos/hierarchical.cpp > b8b9241eae20691ed52c9b5759b17f88a0d8931f > > > Diff: https://reviews.apache.org/r/71301/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
