----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/#review202739 -----------------------------------------------------------
Fix it, then Ship it! configure.ac Lines 2071 (patched) <https://reviews.apache.org/r/66996/#comment284721> We should be able to use `GRPC_VARIANT` here as well as the name should not collide with what we do on the automake side. - Benjamin Bannier On May 9, 2018, 2:50 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66996/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 2:50 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8798 > https://issues.apache.org/jira/browse/MESOS-8798 > > > Repository: mesos > > > Description > ------- > > When the SSL build feature is disabled, Mesos now builds > `libgrpc_unsecure` and `libgrpc++_unsecure` instead of `libgrpc` and > `libgrpc++`, so the SSL headers and libraries are no longer required. > > > Diffs > ----- > > 3rdparty/Makefile.am 8d9fa85dd65a94d91670d54dab36deea80d14996 > configure.ac 429797c35b93a6df69ba0cb0fc28cb66a3171074 > src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 > src/python/native_common/ext_modules.py.in > 87387fd580c40b252fc82f98b5238b9b9120903a > > > Diff: https://reviews.apache.org/r/66996/diff/2/ > > > Testing > ------- > > This patch does not work standalone. Tests are done in the next patch. > > > Thanks, > > Chun-Hung Hsiao > >
