----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62472/#review201447 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Line 175 (original), 177 (patched) <https://reviews.apache.org/r/62472/#comment282685> Remove an extra space between ] and (. src/slave/containerizer/mesos/containerizer.cpp Lines 193 (patched) <https://reviews.apache.org/r/62472/#comment282686> ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 203 (patched) <https://reviews.apache.org/r/62472/#comment282687> ditto. src/slave/containerizer/mesos/containerizer.cpp Lines 210 (patched) <https://reviews.apache.org/r/62472/#comment282688> Should we have this `,`? src/slave/containerizer/mesos/containerizer.cpp Lines 342-343 (original), 349-350 (patched) <https://reviews.apache.org/r/62472/#comment282745> the order is different in the code below, should we switch the comment? src/slave/containerizer/mesos/containerizer.cpp Line 345 (original), 352 (patched) <https://reviews.apache.org/r/62472/#comment282746> add gpu isolator? src/slave/containerizer/mesos/containerizer.cpp Lines 375 (patched) <https://reviews.apache.org/r/62472/#comment282743> typo? src/slave/containerizer/mesos/containerizer.cpp Lines 432 (patched) <https://reviews.apache.org/r/62472/#comment282747> This is my fault from previous TODO. could you do: s/will/will not/g? src/slave/containerizer/mesos/containerizer.cpp Lines 426-430 (original), 446-450 (patched) <https://reviews.apache.org/r/62472/#comment282744> add comment for netowrk isolators? - Gilbert Song On Sept. 21, 2017, 10:47 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62472/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 10:47 a.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Kevin > Klues. > > > Bugs: MESOS-7643 > https://issues.apache.org/jira/browse/MESOS-7643 > > > Repository: mesos > > > Description > ------- > > Historically, isolators were invoked in the order listed by > the operator in the `--isolation` flag. This changed to an > internal ordering in 6fb9c024, back to the operator ordering > in af474a6fa, and then to an undefined ordering in 9642d3c67b. > > This commit switches back to an internal ordering for all the built-in > isolators. Custom isolators loaded in modules are run in operator order > after all the built-in ones. The rationale for an internal ordering is > expressed in MESOS-5581; basically we should not burden the operator > with having to figure out how to make the order correct. In the case of > custom isolators there's no way for us to know the correct ordering so > we make an arbitrary choice. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 4d5dc13f363f5d8886983d7dd06a5cecc177c345 > > > Diff: https://reviews.apache.org/r/62472/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > Posting this as an RFC. If reviewers are OK with the approach, I'll float it > on users@ and dev@ and update the documentation. > > > Thanks, > > James Peach > >
