----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201156 -----------------------------------------------------------
Patch looks great! Reviews applied: [66615] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 13, 2018, 11:57 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66615/ > ----------------------------------------------------------- > > (Updated April 13, 2018, 11:57 p.m.) > > > Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and > Zhitao Li. > > > Repository: mesos > > > Description > ------- > > The Docker containerizer tests were manually creating the `TaskInfo` > for the tasks they wanted to launch. We can remove some of that > boilerplate by adopting the `createTask` helper. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 847258daadf3c37d9071151616b18fc79d850ce8 > src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e > > > Diff: https://reviews.apache.org/r/66615/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 27). > > > Thanks, > > James Peach > >
