----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/#review201126 -----------------------------------------------------------
src/docker/executor.cpp Lines 405 (patched) <https://reviews.apache.org/r/66283/#comment282117> Suggest: ``` Killing task $TASKID which exceeded its maximum completion time of $DURATION ``` src/docker/executor.cpp Lines 412 (patched) <https://reviews.apache.org/r/66283/#comment282113> `shutdown()` runs `killTask()` with a grace period, so I think that you need to do more here. Something like this would work: ``` killed = true; killTask(driver, taskId, 0 /* grace */); ``` src/docker/executor.cpp Lines 500 (patched) <https://reviews.apache.org/r/66283/#comment282114> Move this up into the `if`. src/docker/executor.cpp Lines 571 (patched) <https://reviews.apache.org/r/66283/#comment282115> You can omit this block since it can't happen because you only get here when `failReason` is `None`. src/docker/executor.cpp Lines 830 (patched) <https://reviews.apache.org/r/66283/#comment282116> Like the commant executor, I think you might as well be more explicit here with a `killedByCompletionTimeout` flag. - James Peach On April 8, 2018, 12:52 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66283/ > ----------------------------------------------------------- > > (Updated April 8, 2018, 12:52 a.m.) > > > Review request for mesos, Jason Lai and James Peach. > > > Bugs: MESOS-8725 > https://issues.apache.org/jira/browse/MESOS-8725 > > > Repository: mesos > > > Description > ------- > > If `TaskInfo.max_completion_time` is set, docker executor will kill > the task immediately. We reuse the `shutdown` method to achieve a > forced kill ignoring any `KillPolicy`. > > Framework should only received a `TASK_FAILED` state with > `REASON_MAX_COMPLETION_TIME_REACHED` reason. > > > Diffs > ----- > > src/docker/executor.cpp 1d672112bae889cc9d19343a59e0ff66569785c4 > > > Diff: https://reviews.apache.org/r/66283/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
