> On April 10, 2018, 11:39 a.m., Greg Mann wrote:
> > src/internal/evolve.hpp
> > Line 152 (original), 152-153 (patched)
> > <https://reviews.apache.org/r/66489/diff/1/?file=1993600#file1993600line158>
> >
> > Can we get rid of the `mesos::` here as well?
Nope, if we get rid of `mesos::` here, it will complain about not finding
`mesos::internal::master::Response`:
```
../../src/internal/evolve.hpp:152:40: error: ‘Event’ in namespace
‘mesos::internal::master’ does not name a type
v1::master::Event evolve(const master::Event& event);
^~~~~
../../src/internal/evolve.hpp:153:43: error: ‘Response’ in namespace
‘mesos::internal::master’ does not name a type
v1::master::Response evolve(const master::Response& response);
^~~~~~~~
```
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66489/#review200833
-----------------------------------------------------------
On April 6, 2018, 5:16 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66489/
> -----------------------------------------------------------
>
> (Updated April 6, 2018, 5:16 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes the `mesos::` prefix from declarations where
> possible, uses a consistent number of empty lines in the header,
> and reorders some declarations.
>
>
> Diffs
> -----
>
> src/internal/evolve.hpp e00ac7175438f758b10c0aa9485fc29ffa4efa29
> src/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67
>
>
> Diff: https://reviews.apache.org/r/66489/diff/1/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
