----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200685 -----------------------------------------------------------
3rdparty/stout/include/stout/os/read.hpp Lines 117-127 (patched) <https://reviews.apache.org/r/66431/#comment281536> I can't find much information on the implementation detailfs of `std::wifstream` in Visual C++. I'd like to be certain that it uses `CreateFileW` to open a handle, in which case this long path will work. I'm also not certain if we need to use `std::wifstream`; we could use `std::ifstream file(stringify(longpath.data()))` and avoid the `stringify` of the file contents (which we probably want to avoid). Thoughts? - Andrew Schwartzmeyer On April 6, 2018, 4:11 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66431/ > ----------------------------------------------------------- > > (Updated April 6, 2018, 4:11 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8676 > https://issues.apache.org/jira/browse/MESOS-8676 > > > Repository: mesos > > > Description > ------- > > This can eventually support overlapped I/O. > > The Windows API `ReadFile()` returns an error if the pipe is broken, > where `_read()` did not, but this is not an error for us as the data > is still read correctly. So we ignore it. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/read.hpp > 49878e499209fa2f91fede0ebdabb8f088a9d018 > 3rdparty/stout/include/stout/os/windows/read.hpp > 8047ad590fcc46d3ec46b551472d8c518ae49cc1 > > > Diff: https://reviews.apache.org/r/66431/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
