----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review200471 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 398 (patched) <https://reviews.apache.org/r/66001/#comment281213> No need to return a `Future` here, can be just `void`. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 415 (patched) <https://reviews.apache.org/r/66001/#comment281212> We don't give any grace period here, its mention should be removed from the comment. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 417 (patched) <https://reviews.apache.org/r/66001/#comment281211> Shouldn't this be `quotaInfo->used > quotaInfo->softLimit`? Why punish containers that are within the requested limits. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 544 (patched) <https://reviews.apache.org/r/66001/#comment281214> I may be missing something here, why do you need this? Are you capturing this `PID` in lambdas for something? Object lifetime extension (AFAIK it doesn't work like that, though I may be wrong)? - Ilya Pronin On April 4, 2018, 10:41 a.m., Harold Dost wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66001/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 10:41 a.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-6575 > https://issues.apache.org/jira/browse/MESOS-6575 > > > Repository: mesos > > > Description > ------- > > New Flags for disk/xfs isolator: > - xfs_kill_containers - This will create a 10 MB buffer between the soft > and hard limits, and when the soft limit is exceeded it will > subsequently be killed. > > Functionality > - This by default disabled behavior allows for the `disk/xfs` isolator > to kill containers which surpass their limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 07e68a777aefba4dd35066f2eb207bba7f199d83 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 8d9f8f846866f9de377c59cb7fb311041283ba70 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > e034133629a9c1cf58b776f8da2a93421332cee0 > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > 2708524add1ff693b616d4fb241c4a0a3070520b > src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 > src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 > src/tests/containerizer/xfs_quota_tests.cpp > 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe > > > Diff: https://reviews.apache.org/r/66001/diff/12/ > > > Testing > ------- > > > Thanks, > > Harold Dost > >
