> On March 14, 2018, 9:32 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 172 (patched) > > <https://reviews.apache.org/r/66007/diff/1/?file=1973214#file1973214line172> > > > > I am surprised that this does not disable permissive mode for msvc. Is > > that the case? Sounds like it might warrant a bug report against cmake.
I checked the CMake sources on this one. This controls e.g. `-std=gnu++11` vs `-std=c++11`, not `/permissive-`. Moreover, that was an option very recently added to MSVC; and it's not equivalent to disabling extensions, as it also disables stuff like allowing `&static_cast<void*>(ptr)` (address-of a temporary). - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199177 ----------------------------------------------------------- On March 9, 2018, 2:37 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66007/ > ----------------------------------------------------------- > > (Updated March 9, 2018, 2:37 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John > Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8033 > https://issues.apache.org/jira/browse/MESOS-8033 > > > Repository: mesos > > > Description > ------- > > Instead of setting the compiler option manually, we use the > `CMAKE_CXX_STANDARD` variable to set the default for all targets. This > automatically appends the correct flag for each compiler. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54 > > > Diff: https://reviews.apache.org/r/66007/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
