----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/#review199122 -----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp Lines 2892 (patched) <https://reviews.apache.org/r/65995/#comment279432> nit: s/decline/declined/ - Gaston Kleiman On March 13, 2018, 2:45 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65995/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 2:45 p.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > The two SLRP tests assume that SLRP will send out a RAW resource in its > first `UPDATE_STATE` message, and expect that the test framework would > receive an offer containing the RAW resource in its first offer. However > this behavior is not guaranteed and should not be relied on. This patch > makes the tests decline unwanted offers by default so they no longer > rely on SLRP's internal behavior. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 264d42b57fe1a8ea04c1de0a10112878c7b45d39 > > > Diff: https://reviews.apache.org/r/65995/diff/2/ > > > Testing > ------- > > sudo make check > Ran the two tests in repitition. > > > Thanks, > > Chun-Hung Hsiao > >
