----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65313/#review199091 -----------------------------------------------------------
Fix it, then Ship it! src/slave/http.cpp Lines 2199-2218 (original), 2031-2039 (patched) <https://reviews.apache.org/r/65313/#comment279384> Not indented enough. src/slave/http.cpp Lines 2250-2276 (original), 2071-2080 (patched) <https://reviews.apache.org/r/65313/#comment279383> Not indented far enough; here and elsewhere. Could you double-check the indentation on these deferred continuations? src/slave/http.cpp Lines 3037-3044 (original), 2857-2864 (patched) <https://reviews.apache.org/r/65313/#comment279382> Not indented far enough. - Greg Mann On March 9, 2018, 1:06 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65313/ > ----------------------------------------------------------- > > (Updated March 9, 2018, 1:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Greg Mann. > > > Bugs: MESOS-8434 > https://issues.apache.org/jira/browse/MESOS-8434 > > > Repository: mesos > > > Description > ------- > > This patch makes uses of the new `ObjectApprovers` class which greatly > simplifies the logic for constructing and using authorization. > > > Diffs > ----- > > src/slave/http.hpp c33adeb2ddd36e8be1324b3ddb1401bdf7e4e80b > src/slave/http.cpp 7d7fa2b4ec2e1f8f65c5264ce72590d0d8195b9b > src/slave/slave.cpp 8cb6899bf15fb697c3cb2784f63b7c2d5729d219 > > > Diff: https://reviews.apache.org/r/65313/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
