----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65918/#review199060 -----------------------------------------------------------
Fix it, then Ship it! src/common/validation.cpp Lines 283 (patched) <https://reviews.apache.org/r/65918/#comment279352> small nits: s/Docker info/DockerInfo/g? - Gilbert Song On March 6, 2018, 12:40 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65918/ > ----------------------------------------------------------- > > (Updated March 6, 2018, 12:40 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8497 > https://issues.apache.org/jira/browse/MESOS-8497 > > > Repository: mesos > > > Description > ------- > > Setting `name` parameter in container's Docker info will cause Docker > containerizer cannot recognize the created Docker container, see > MESOS-8497 for details. So this patch disallows that during validation > stage. > > > Diffs > ----- > > src/common/validation.cpp bad9ea8a712162ba24a9a8ada02fe6cbe48f5c80 > > > Diff: https://reviews.apache.org/r/65918/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
