----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review198812 -----------------------------------------------------------
src/master/master.cpp Line 4136 (original), 4184 (patched) <https://reviews.apache.org/r/63992/#comment279057> If the operation has an operation ID, we'll always land on this `continue` even if the validations/checks pass. This means that line #4187 will be skipped, and operations with an operatin ID won't be added to the object passed to the `_accept` continuation. - Gaston Kleiman On March 2, 2018, 2:52 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63992/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 2:52 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > This patch adds code to send operation status updates in the master's > ACCEPT call handler. In cases where operations are dropped and in > cases where offer operation IDs are set when they should not be, the > master will send operation status updates for the dropped operations. > > > Diffs > ----- > > src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c > > > Diff: https://reviews.apache.org/r/63992/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
