----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198195 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/docker_containerizer_tests.cpp Lines 5188 (patched) <https://reviews.apache.org/r/65750/#comment278302> s/ROOT_DOCKER_InspectDuringPull/ROOT_DOCKER_InspectHungDuringPull/g? src/tests/containerizer/docker_containerizer_tests.cpp Lines 5251-5258 (patched) <https://reviews.apache.org/r/65750/#comment278303> Instead of following the style in this file, could we do `createTask()`? src/tests/containerizer/docker_containerizer_tests.cpp Lines 5284-5285 (patched) <https://reviews.apache.org/r/65750/#comment278304> Could we also verify that the statusFailed's reason is due to TIMEOUT? - Gilbert Song On Feb. 22, 2018, 3:10 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65750/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 3:10 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. > > > Repository: mesos > > > Description > ------- > > The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull' > verifies that the Mesos agent will send a TASK_FAILED > update for a Docker task which fails because the executor > registration timeout elapses while the container is stuck > in the PULLING state due to a hung 'docker inspect' call. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > d1e657050d623ad0412208b3aa3e3101e3654e99 > > > Diff: https://reviews.apache.org/r/65750/diff/2/ > > > Testing > ------- > > sudo bin/mesos-tests.sh > --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull" > > > Thanks, > > Greg Mann > >
