> On Feb. 23, 2018, 8:35 a.m., Andrei Budnik wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5133 (patched) > > <https://reviews.apache.org/r/65751/diff/3/?file=1963501#file1963501line5133> > > > > `os::write()` is not atomical, so we should write to a temporary file, > > then rename it: `mv new_env.tmp test-docker.env`. Otherwise, if someone > > launches docker cli, while the script is being updated - `test-docker.sh` > > might read/import half-written env file. > > > > Probably, we don't need to fix it now.
A TODO sounds ok to me for now. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198184 ----------------------------------------------------------- On Feb. 22, 2018, 3:28 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65751/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 3:28 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. > > > Bugs: MESOS-8591 > https://issues.apache.org/jira/browse/MESOS-8591 > > > Repository: mesos > > > Description > ------- > > The new `HungDockerTest` class allows test authors to force > certain Docker daemon calls to be delayed for a specified > duration. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > d1e657050d623ad0412208b3aa3e3101e3654e99 > > > Diff: https://reviews.apache.org/r/65751/diff/3/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
