> On Jan. 26, 2018, 10:20 p.m., Vinod Kone wrote: > > src/slave/http.cpp > > Lines 1685 (patched) > > <https://reviews.apache.org/r/65044/diff/8/?file=1946618#file1946618line1685> > > > > Not yours, but can we make the logging consistent here and in master > > for operator api handlers? Looks like master doesn't even log here? > > Greg Mann wrote: > Looks like we do log in the master's top-level API handler. So logging is > done in both cases, but we could be more consistent in how/where the logging > is done precisely.
Yes, master logs this in `Master::Http::api` while agents log in their respective handlers. While this is inconsistent, this shouldn't be in the scope of this patch to fix it. Hence I'm dropping the issue. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196370 ----------------------------------------------------------- On Feb. 6, 2018, 11:10 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65044/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2018, 11:10 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie > Yu, and Vinod Kone. > > > Bugs: MESOS-8424 > https://issues.apache.org/jira/browse/MESOS-8424 > > > Repository: mesos > > > Description > ------- > > The 'GET_OPERATIONS' call lists all operations known to master or agent. > > > Diffs > ----- > > include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c > include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd > include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a > include/mesos/v1/master/master.proto > 6759c3004e7e04c0044360b0c54f4438c2f6ec8a > src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 > src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 > src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 > src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 > src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f > > > Diff: https://reviews.apache.org/r/65044/diff/10/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
