----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/#review197174 -----------------------------------------------------------
Fix it, then Ship it! support/post-reviews.py Lines 206-209 (patched) <https://reviews.apache.org/r/65545/#comment277297> This output sounds more scary than I thought, maybe we should prompt the user for input, especially since we ask them a question. Maybe something like try: raw_input('\nPress enter to continue or \'Ctrl-C\' to abort.\n) except KeyboardInterrupt: sys.exit() - Benjamin Bannier On Feb. 7, 2018, 4:22 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65545/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2018, 4:22 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > When posting a review originally created from a branch B, it could happen > that the resulting review included garbage changes if B was updated between > revisions. (i.e., pulling new master changes) > > This review changes the logic of the `post-reviews.py` script to only include > the changes between `HEAD` and the merge base of the tracking branch into the > review. > > > Diffs > ----- > > support/post-reviews.py 94b43253f25044a79009010e92363d1536c74299 > > > Diff: https://reviews.apache.org/r/65545/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
