----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196301 -----------------------------------------------------------
src/master/master.cpp Lines 5841-5850 (patched) <https://reviews.apache.org/r/64618/#comment275850> As discussed offline, let's leave the validation in the top-level scheduler API handler, and increment invalid metrics there. src/master/master.cpp Lines 5877-5895 (patched) <https://reviews.apache.org/r/64618/#comment275851> Per our offline discussion, consider not incrementing invalid metrics in these cases. - Greg Mann On Jan. 23, 2018, 10:17 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64618/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 10:17 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8184 > https://issues.apache.org/jira/browse/MESOS-8184 > > > Repository: mesos > > > Description > ------- > > Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. > > > Diffs > ----- > > src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 > > > Diff: https://reviews.apache.org/r/64618/diff/2/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
