----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/#review195635 -----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp Lines 981 (patched) <https://reviews.apache.org/r/65000/#comment274898> s/becomes a pre-existing volume/become pre-existing volumes/ src/tests/storage_local_resource_provider_tests.cpp Lines 1003-1011 (patched) <https://reviews.apache.org/r/65000/#comment274900> Can you do something like: ``` agentFlags.agent_features = SlaveCapabilities(); agentFlags.agent_features->add_capabilities()->set_type( SlaveInfo::Capability::RESOURCE_PROVIDER); ``` src/tests/storage_local_resource_provider_tests.cpp Lines 1039-1040 (patched) <https://reviews.apache.org/r/65000/#comment274902> Same question here as in a previous review, regarding potential raciness of the first offer. Have you tested this under load? src/tests/storage_local_resource_provider_tests.cpp Lines 1051 (patched) <https://reviews.apache.org/r/65000/#comment274903> s/volume/volumes/ src/tests/storage_local_resource_provider_tests.cpp Lines 1151-1158 (patched) <https://reviews.apache.org/r/65000/#comment274905> There doesn't seem to be anything here which verifies that the agent has registered with a new ID? You could await on a `FUTURE_PROTOBUF(SlaveRegisteredMessage(), _, _)` to ensure this. src/tests/storage_local_resource_provider_tests.cpp Lines 1041-1043 (original), 1240-1242 (patched) <https://reviews.apache.org/r/65000/#comment274906> Are these changes, and the rest below, meant to go in this RR? - Greg Mann On Jan. 10, 2018, 2:34 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65000/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 2:34 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8409 > https://issues.apache.org/jira/browse/MESOS-8409 > > > Repository: mesos > > > Description > ------- > > Added an SLRP test for agent being registered with a new ID. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > bbfe95e9818f25fdd5405db3ad2fe355e023f743 > > > Diff: https://reviews.apache.org/r/65000/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
