----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/#review195412 -----------------------------------------------------------
src/tests/resource_provider_manager_tests.cpp Lines 1345 (patched) <https://reviews.apache.org/r/65126/#comment274586> This does look more like an agent integration test to me; maybe move it to `slave_tests.cpp` instead? src/tests/resource_provider_manager_tests.cpp Lines 1440-1443 (patched) <https://reviews.apache.org/r/65126/#comment274585> Even though it works I think having the setup expecations for side-effects before triggering it. Let's move these two above the `send` just above. src/tests/resource_provider_manager_tests.cpp Lines 1448 (patched) <https://reviews.apache.org/r/65126/#comment274583> We need to make a hard assert that `offers` is not empty. src/tests/resource_provider_manager_tests.cpp Lines 1453-1454 (patched) <https://reviews.apache.org/r/65126/#comment274584> Since these are the core pieces we test here, we use expectations instead of assertions here. - Benjamin Bannier On Jan. 12, 2018, 3:16 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65126/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 3:16 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8445 > https://issues.apache.org/jira/browse/MESOS-8445 > > > Repository: mesos > > > Description > ------- > > Added a resource provider test case. > > > Diffs > ----- > > src/tests/resource_provider_manager_tests.cpp > d80823c47963e969113dae3623b18b7639c890fc > > > Diff: https://reviews.apache.org/r/65126/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
