----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65137/#review195379 -----------------------------------------------------------
src/master/master.cpp Lines 10358-10359 (patched) <https://reviews.apache.org/r/65137/#comment274550> Whoops! Looks like we won't actually push the first status onto the list as written. Should probably be: ``` if (operation->statuses().empty() || *(operation->statuses().rbegin()) != status) { ``` - Greg Mann On Jan. 13, 2018, 12:28 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65137/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2018, 12:28 a.m.) > > > Review request for mesos, Benjamin Bannier and Greg Mann. > > > Repository: mesos > > > Description > ------- > > This patch adds some logic to deduplicate the status updates that are > added to `Operation::statuses`. The logic is consistent with the > handling of task status updates, but we should revisit it in MESOS-8441. > > > Diffs > ----- > > src/master/master.cpp c96cd7090875fbf1b11b1708390e88182c77655b > > > Diff: https://reviews.apache.org/r/65137/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh` on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
