----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65050/#review195075 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/isolators/filesystem/linux.cpp Lines 604-605 (original), 611-612 (patched) <https://reviews.apache.org/r/65050/#comment274214> The code looks correct but the review summary seems not accurate: we are more benefitting from the fact that in these isolators we set `info->resources` only after we update the volumes on disk. Docker containerizer has the same `if (current.contains(resource))` check but that check doesn't work because we set `container->resources` first there. - Jiang Yan Xu On Jan. 9, 2018, 12:44 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65050/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 12:44 p.m.) > > > Review request for mesos, Gilbert Song, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-8356 > https://issues.apache.org/jira/browse/MESOS-8356 > > > Repository: mesos > > > Description > ------- > > This patch adds some defensive checks for detecting if a persistent > volume is shared by multiple containers. It's currently not a bug > because of a `contains` check above in the loop body. But this is a bit > fragile and should be avoided. > > See more details in MESOS-8356. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 5200182970fa978e940d3f0e9cddce37608e84f7 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 6b9f4bb42621eec3eb648712fbfa41d94f253895 > > > Diff: https://reviews.apache.org/r/65050/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
