----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65048/#review195070 -----------------------------------------------------------
Can you update the description as well? > If a socket create or connect failure occurs during link() or send(), it is > not propagated to the library user. This isn't quite accurate, a link failure is propagated via an exited message. Or did you mean the reason for the error? Can you clarify this? - Benjamin Mahler On Jan. 9, 2018, 6:19 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65048/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 6:19 p.m.) > > > Review request for mesos, Andrei Budnik and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > If a socket create or connect failure occurs during link() or send(), > it is not propagated to the library user. Also, the data being sent or > queued is silently dropped on the floor. The socket code does not log > itself on a higher level when an error situation occurs. The only > trace is the log entries touched in this patch: having them at warning > level will significantly simplify debugging. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 53969a79f5e877b955dcab5c3ab9e508ebe96e88 > > > Diff: https://reviews.apache.org/r/65048/diff/1/ > > > Testing > ------- > > None. > > > Thanks, > > Alexander Rukletsov > >
