----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64864/#review194605 -----------------------------------------------------------
Fix it, then Ship it! LGTM! src/authorizer/local/authorizer.cpp Lines 1703-1704 (patched) <https://reviews.apache.org/r/64864/#comment273469> oneline? src/slave/http.cpp Lines 2462-2463 (original), 2482-2483 (patched) <https://reviews.apache.org/r/64864/#comment273468> oneline? - Gilbert Song On Dec. 28, 2017, 12:05 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64864/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2017, 12:05 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-8365 > https://issues.apache.org/jira/browse/MESOS-8365 > > > Repository: mesos > > > Description > ------- > > Added authorization for prune images API call. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 5c7ed340a41a6808e4bf25cc38b54c7b07d7bb63 > include/mesos/authorizer/authorizer.proto > 90ffdfa0c0d96c5d682441d318b83e6ad857d09b > src/authorizer/local/authorizer.cpp > 0722ac9d673a7829b762cce60b2cb9bfc190ab11 > src/slave/http.cpp 446be55f7bff26d35400e79982cb08d37c9c739f > > > Diff: https://reviews.apache.org/r/64864/diff/1/ > > > Testing > ------- > > Tested locally for the cases: > - allowing any principal to prune images; > - allowing no principal to prune images. > > > Thanks, > > Zhitao Li > >
