----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64761/#review194292 -----------------------------------------------------------
Fix it, then Ship it! Looks good, modulo stripping the resources when decrementing the required & available headroom. src/master/allocator/mesos/hierarchical.cpp Lines 1955-1956 (patched) <https://reviews.apache.org/r/64761/#comment273037> Should these be stripped? - Benjamin Mahler On Dec. 21, 2017, 1:11 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64761/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 1:11 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7099 > https://issues.apache.org/jira/browse/MESOS-7099 > > > Repository: mesos > > > Description > ------- > > This paves the way for improved quota headroom enforcement > for the quota role allocation stage. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 1c767f7f778819dcfa6eff51765163aec1b70a2d > > > Diff: https://reviews.apache.org/r/64761/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
