----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64648/#review193932 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 15, 2017, 1:15 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64648/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2017, 1:15 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Agents can use 'UpdateSlaveMessage' to send updates on their > oversubscribed resources, their resource provider state, or both. We > previously assumed that 'UpdateSlaveMessage' from a resource > provider-capable agent would always contain the most recent resource > version of the agent even thought the field is marked 'optional'. > > This patch simplifies the handling in the master to not assert a set > resource version for 'UpdateSlaveMessage' for resource > provider-capable agents. Instead we explicitly and unconditionally > check whether the field is set and handle only set values. > > > Diffs > ----- > > src/master/master.cpp e082da8267fa22c26818c67bd6da573fe1808696 > > > Diff: https://reviews.apache.org/r/64648/diff/1/ > > > Testing > ------- > > Tested on a number of platforms and setups in internal CI. > > > Thanks, > > Benjamin Bannier > >
