> On Dec. 14, 2017, 8:35 a.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 7506 (patched) > > <https://reviews.apache.org/r/64589/diff/1/?file=1915763#file1915763line7528> > > > > This `CHECK` is not sufficient to make sure that `converted_resources` > > is set -- the operation could e.g., be terminal and failed. > > > > Could we instead assert that the operation is > > `OFFER_OPERTATION_FINISHED`? Alternatively we might also make sure that > > every terminal operation sets `converted_resources`, in case of failures > > e.g., to `consumed`. > > Chun-Hung Hsiao wrote: > Agreed. That's part of the reason I feel we should keep `apply` receiving > `ResourceConversion`s and not duplicating the CHECK logic all around.
Just ResourceConversion is not sufficient, i need to get the resource provider ID, and I don't want to infer that from ResourceConversions. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64589/#review193772 ----------------------------------------------------------- On Dec. 14, 2017, 1:38 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64589/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 1:38 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > The bug is introduced in this patch: > https://reviews.apache.org/r/64477/ > > Given that we also keep track of each resource provider's total > resources in addition to the total resources of the agent, we need to > make sure we update those totals after applying an operation. > > The bug may manifest as a CHECK failure in the agent that checks if > `totalResources` of the agent is a super set of all the resource > provider resources. > > > Diffs > ----- > > src/slave/slave.hpp de2b2e2e81ed860e6a33ce1b93d859d816ba1021 > src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d > > > Diff: https://reviews.apache.org/r/64589/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
