----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64546/#review193794 -----------------------------------------------------------
Fix it, then Ship it! src/tests/resource_provider_manager_tests.cpp Lines 1107 (patched) <https://reviews.apache.org/r/64546/#comment272442> Not added here, but the `Some` here is redundant. src/tests/resource_provider_manager_tests.cpp Lines 1181 (patched) <https://reviews.apache.org/r/64546/#comment272444> The `Some` here is redundant. - Benjamin Bannier On Dec. 14, 2017, 11:35 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64546/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 11:35 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu. > > > Bugs: MESOS-8315 > https://issues.apache.org/jira/browse/MESOS-8315 > > > Repository: mesos > > > Description > ------- > > Callbacks of already invalidated instances could be called in > 'ResubscribeResourceProvider' when simulating a resource provider > restart. This has been resolved by not only restart a resource > provider's driver, but creating a new 'MockResourceProvider' instance. > > > Diffs > ----- > > src/tests/resource_provider_manager_tests.cpp > 41fc4ea592eed49bd03d7e78019fa647f4f6e652 > > > Diff: https://reviews.apache.org/r/64546/diff/2/ > > > Testing > ------- > > make check > > src/mesos-tests > --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* > --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the > background) > > > Thanks, > > Jan Schlicht > >
