----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64494/#review193415 -----------------------------------------------------------
FAIL: Failed to apply the current review. Failed command: `python.exe .\support\apply-reviews.py -n -r 64494` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64494 Relevant logs: - [apply-review-64494-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64494/logs/apply-review-64494-stderr.log): ``` Traceback (most recent call last): File ".\support\apply-reviews.py", line 434, in <module> main() File ".\support\apply-reviews.py", line 429, in main reviewboard(options) File ".\support\apply-reviews.py", line 419, in reviewboard apply_review(options) File ".\support\apply-reviews.py", line 160, in apply_review commit_patch(options) File ".\support\apply-reviews.py", line 271, in commit_patch message.write(data['message']) UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 430: ordinal not in range(128) ``` - Mesos Reviewbot Windows On Dec. 11, 2017, 4:59 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64494/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2017, 4:59 a.m.) > > > Review request for mesos, Benjamin Bannier and Greg Mann. > > > Repository: mesos > > > Description > ------- > > It's not correct to send resource version uuids for local resources > providers during agent re(registration) because the total resources from > those local resource providers are not sent in the same message. > > Consider the following sequence of events: > (1) Agent disconnects > (2) Speculative operation fails in an RP, the RP bumps the version uuid > (3) Agent updates the RP’s resource version uuid > (4) Agent reregisters > (5) Master is informed about the new resource version uuid of that RP > (6) Master still has the old total of the RP > (7) Framework launch an operation assuming the old total, but with the > new resource version uuid > > This patch updated the `RegisterSlaveMessage` and > `ReregisterSlaveMessage` to only send resource version uuids for the > agent default resources. > > > Diffs > ----- > > src/master/master.hpp 5c26f2066aae31223ffdd76ed058d5a4e63a2603 > src/master/master.cpp b3e074cfe86600793310deb87932fa145e95055d > src/messages/messages.proto a13a6410891a45876b4458369c282aa4d502db08 > src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235 > src/tests/slave_tests.cpp 0fb2a63a5c9e7bd353c4f1b8f8f32e58e3e12e94 > > > Diff: https://reviews.apache.org/r/64494/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
