> On Nov. 7, 2017, 12:37 a.m., Qian Zhang wrote: > > src/master/master.cpp > > Lines 9674-9676 (original), 9675-9678 (patched) > > <https://reviews.apache.org/r/61128/diff/1/?file=1782402#file1782402line9675> > > > > To be consistent with this log message, I think we also need to change > > the log message in `Master::removeTask()` from: > > ``` > > LOG(INFO) << "Removing task " << task->task_id() > > << " with resources " << task->resources() > > << " of framework " << task->framework_id() > > << " on agent " << *slave; > > ``` > > to: > > ``` > > LOG(INFO) << "Removing task " << task->task_id() > > << " of framework " << task->framework_id() > > << " with resources " << task->resources() > > << " on agent " << *slave; > > ``` > > And there is also a warning message in `Master::removeTask()`, I think > > we need to change that one too.
Made it consistent. Also moved the location of the logs to be consistent. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/#review190253 ----------------------------------------------------------- On Dec. 6, 2017, 1:33 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61128/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 1:33 a.m.) > > > Review request for mesos, Benno Evers and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Made the log messages and the calling sites consistent and also added > one for adding an executor. > > > Diffs > ----- > > src/master/master.cpp 16cdde73b90b2e1514c6196850b8df75a3b6ff28 > > > Diff: https://reviews.apache.org/r/61128/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
