----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64180/#review192208 -----------------------------------------------------------
Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:44 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64180/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 10:44 p.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Bugs: MESOS-5881 > https://issues.apache.org/jira/browse/MESOS-5881 > > > Repository: mesos > > > Description > ------- > > This resolves MESOS-5881 and simplifies `create_symbolic_link()`. Links > to non-existent targets are allowed on Windows. Relative paths for links > and targets are also valid. > > This enables two tests which had been disabled due to the previous > implementation not allowing links to non-existent files. The `OsTest` > uncovered more uses of CRT APIs in the Windows `stat` implementation. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > e3d04480cf793482d958ea9571d96a29b6bf09b1 > 3rdparty/stout/include/stout/os/windows/stat.hpp > 0db6d482ad19897db33d334bffe4b294da11a36f > 3rdparty/stout/tests/os/rmdir_tests.cpp > 86ec62352672d90d146b9097e7daa914ccdbb691 > 3rdparty/stout/tests/os_tests.cpp 959b02d08f06481a64ef1a39acf23b062d5dc805 > > > Diff: https://reviews.apache.org/r/64180/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
