----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review191629 -----------------------------------------------------------
PASS: Mesos patch 63953 was successfully built and tested. Reviews applied: `['63953']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63953 - Mesos Reviewbot Windows On Nov. 21, 2017, 5:12 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63953/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 5:12 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-7361 > https://issues.apache.org/jira/browse/MESOS-7361 > > > Repository: mesos > > > Description > ------- > > This change enables filtering when printing logs regarding > containers. If its class is `DEBUG` we print the log line at a > verbose level 1 otherwise we print is at the `INFO` level. > > We use the added macro in containerizer.cpp so that COMMAND health > checks cause less INFO logs (15 instead of 26 before). > > > Diffs > ----- > > src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 > src/logging/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > 7f3b86d87cf82429c2627d4a32eb0d5adbcc3f29 > > > Diff: https://reviews.apache.org/r/63953/diff/4/ > > > Testing > ------- > > Started a Mesos cluster and used `mesos-execute` with this task group to > check that the behaviour after this patch was the one expected: > > ``` > { > "tasks": [ > { > "name": "Name of the task", > "task_id": { > "value": "task-group" > }, > "agent_id": { > "value": "" > }, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.01 > } > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 2 > } > } > ], > "command": { > "value": "sleep 1000" > }, > "check": { > "type": "COMMAND", > "command": { > "command": { > "value": "echo \"Bonjour\"" > }, > "uris": [] > } > } > } > ] > } > ``` > > And: > ``` > $ nice make check > ``` > > > Thanks, > > Armand Grillet > >
