----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review191607 -----------------------------------------------------------
include/mesos/resource_provider/resource_provider.proto Lines 141 (patched) <https://reviews.apache.org/r/62502/#comment269451> I think we need a way to tell the RP manager if the publish request is successful or not. Also I checked our naming convention and it seems "Acknowledge" is not the best name for this (my bad). How about the following? ``` message UpdatePublishStatus { enum State { UNKNOWN = 0; OK = 1; FAILED = 2; } required bytes uuid = 1; required State state = 2; optional string message = 3; } ``` include/mesos/v1/resource_provider/resource_provider.proto Lines 141 (patched) <https://reviews.apache.org/r/62502/#comment269452> Ditto. - Chun-Hung Hsiao On Nov. 21, 2017, 11:55 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62502/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 11:55 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. > > > Bugs: MESOS-8089 > https://issues.apache.org/jira/browse/MESOS-8089 > > > Repository: mesos > > > Description > ------- > > Before launching a task that use resource provider resources, the Mesos > master will instruct the resource provider to make these resources > available for the task. External resource providers will checkpoint > informations to be able to reconcile resource usage in case of a > failover. Resource providers will acknowledge the 'PUBLISH' > operations by sending back 'ACKNOWLEDGE_PUBLISH' together with > the UUID of the operation. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto > 1e44b952691fa57b546e979bc5876df3d82d746f > include/mesos/v1/resource_provider/resource_provider.proto > 3956f82f734458bc3c7ee6813f2784f3d4767cd8 > src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43 > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > src/resource_provider/validation.cpp > ddc57c3eac70c4b105785f214357e27d84a93332 > src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb > > > Diff: https://reviews.apache.org/r/62502/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
