----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63984/#review191574 -----------------------------------------------------------
3rdparty/libprocess/Makefile.am Line 399 (original), 399-401 (patched) <https://reviews.apache.org/r/63984/#comment269416> With this we can now build `BUNDLED_DEPS` (which might include protobuf itself) in parallel with e.g., `BENCHMARKS_PROTOS`. This is incorrect as `BENCHMARK_PROTOS` depends on protobuf existing (when bundled this means compiled). Could you add an explicit dependency to make sure these builds are correctly ordered, e.g., %pb.cc %pb.h: src/tests/%.proto $(BUNDLED_DEPS) (similar for `*.grpc.pb.*` files)? This is strongly related to https://reviews.apache.org/r/62777/. - Benjamin Bannier On Nov. 21, 2017, 2:32 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63984/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 2:32 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Sometimes `libprocess` can fail to build due to missing protobuf files. > This adds protobufs to `BUILT_SOURCES` to ensure they are generated > before other files are compiled. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 896be0c6fd2cca514a226f861574e37f89befa1e > > > Diff: https://reviews.apache.org/r/63984/diff/1/ > > > Testing > ------- > > rm -r build > mkdir build > cd build > ../configure > make check > > > Thanks, > > Dmitry Zhuk > >
